Re: Renaming of pg_xlog and pg_clog

From: Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Renaming of pg_xlog and pg_clog
Date: 2016-08-27 09:13:00
Message-ID: d36d10ef-5dd8-7b4f-6c44-a25a0584d5d4@archidevsys.co.nz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 27/08/16 20:33, Michael Paquier wrote:
> On Sat, Aug 27, 2016 at 6:34 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> On 2016-08-26 17:31:14 -0400, Peter Eisentraut wrote:
>>> I agree with all that. But the subject line is specifically about
>>> moving pg_xlog. So if your opinion is that we shouldn't move pg_xlog,
>>> then that is noted. But if we were to move it, we can think about a
>>> good place to move it to.
>> I think it's probably worth moving pg_xlog, because the benefit also
>> includes preventing a few users from shooting themselves somewhere
>> vital. That's imo much less the case for some of the other moves. But I
>> still don't think think a largescale reorganization is a good idea,
>> it'll just stall and nothing will happen.
> OK, so let's focus only on the renaming mentioned in $subject. So far
> as I can see on this thread, here are the opinions of people who
> clearly gave one:
> - Rename them, hard break is OK: Michael P, Bruce, Stephen (depends on
> David's input), Magnus
> - Rename them, hard break not OK: Fujii-san (perhaps do nothing?)
> - Do nothing: Simon (add a README), Tom, Peter E
>
> As far as I can see, there is a consensus to not rename pg_xlog to
> pg_journal and avoid using a third meaning, but instead use pg_wal. I
> guess that now the other renaming would be pg_clog -> pg_xact. Other
> opinions? Forgot you here?

I think if there are going to be things in pg that break software - for
good reasons, like making future usage easier at the cost an initial
sharp pain - then to do so in version '10.0.0' is very appropriate! IMHO

And better to do so in 10.0.0 (especially if closely related), rather
than 10.1.0 (or whatever the next version after that is named). So, if
other things might cause breakages, do so IN 10.0.0 - rather than hold
back - assuming that there won't be hundreds or more major breakages!!!

Cheers,
Gavin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2016-08-27 09:16:06 Re: WAL consistency check facility
Previous Message Michael Paquier 2016-08-27 08:33:14 Re: Renaming of pg_xlog and pg_clog