Re: libpq_pipeline in tmp_install

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: libpq_pipeline in tmp_install
Date: 2021-05-19 10:09:35
Message-ID: d35be8c9-3c8e-25a6-298b-fd9ddcb1a02b@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10.05.21 20:26, Peter Eisentraut wrote:
> The test program libpq_pipeline produced by the test suite in
> src/test/modules/libpq_pipeline/ is installed into tmp_install as part
> of make check.  This isn't a real problem by itself, but I think it
> creates a bit of an asymmetric situation that might be worth cleaning up.
>
> Before, the contents of tmp_install exactly matched an actual
> installation.  There were no extra test programs installed.
>
> Also, the test suite code doesn't actually use that installed version,
> so it's not of any use, and it creates confusion about which copy is in
> use.
>
> The reason this is there is that the test suite uses PGXS to build the
> test program, and so things get installed automatically.  I suggest that
> we should either write out the build system by hand to avoid this, or
> maybe extend PGXS to support building programs but not installing them.

Here is a patch that implements the second solution, which turned out to
be very easy.

Attachment Content-Type Size
0001-Add-NO_INSTALL-option-to-pgxs.patch text/plain 1.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-05-19 10:24:09 Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing.
Previous Message Bharath Rupireddy 2021-05-19 09:37:52 Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options