| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Nathan Bossart" <nathandbossart(at)gmail(dot)com>, "Yugo Nagata" <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove an unnecessary blank line on the PQisBusy() comments |
| Date: | 2025-10-23 15:19:03 |
| Message-ID: | d3293bb3-9798-4846-abfd-ca78b57bf5aa@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 23, 2025, at 12:11 PM, Nathan Bossart wrote:
> On Thu, Oct 23, 2025 at 08:02:03PM +0900, Yugo Nagata wrote:
>> I’ve attached a very trivial patch that removes an unnecessary line
>> after the comments on PQisBusy(), just for consistency with the
>> surrounding code.
>
> Given this line has been there for 28 years (commit edbd513) and isn't
> hurting anything, I don't see a strong need to change it.
>
In this same file there are other cases of blank line after comment and before
function definition. If, in the future, we have an automated tool (pgindent?)
that removes such blank line(s) after comment and before function definition, I
would say fix it. That's not the case; I would leave it alone.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-10-23 15:38:32 | Re: issue with synchronized_standby_slots |
| Previous Message | Jacob Champion | 2025-10-23 15:17:06 | Re: Git clone over git protocol fails |