Re: Re: Clarifying "server starting" messaging in pg_ctl start without --wait

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Ryan Murphy <ryanfmurphy(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: Clarifying "server starting" messaging in pg_ctl start without --wait
Date: 2017-01-17 16:27:41
Message-ID: d20bac37-c764-fb02-3f8d-886969e807eb@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/15/17 11:40 PM, Fujii Masao wrote:
> This change may confuse the users who run "pg_ctl start" to perform a crash
> recovery, archive recovery and standby server (with hot_standby=off) because
> "pg_ctl start" would not return so long time.

Well, this change was made because the previous behavior confused people
as well, because pg_ctl would return before it was actually done.

The new state shouldn't be confusing because pg_ctl prints out progress
messages.

> Also during that long time,
> the error message "FATAL: the database system is starting up" keeps outputing.

We could potentially avoid some of this by using the new facilities in
pg_ctl to read pg_control and not use PQping() before the state is out
of DB_IN_CRASH_RECOVERY.

Note, however, that this isn't a new problem. The way pg_ctl start -w
is implemented hasn't changed.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-01-17 16:34:41 Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal
Previous Message Tom Lane 2017-01-17 16:21:31 Re: New CORRESPONDING clause design