| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: automatically generating node support functions |
| Date: | 2022-07-06 10:30:49 |
| Message-ID: | d200d6b0-0fde-d02e-b547-d00211acf8df@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06.07.22 02:54, Tom Lane wrote:
> It might be enough to invent a struct-level attribute allowing
> manual assignment of node tags, ie
>
> typedef struct MyNewNode pg_node_attr(nodetag=466)
>
> where it'd be the programmer's responsibility to pick a nonconflicting
> tag number. We'd only ever use that in ABI-frozen branches, so
> manual assignment of the tag value should be workable.
Yes, I'm aware of this issue, and that was also more or less my idea.
(Well, before the introduction of per-struct attributes, I was thinking
about parsing nodes.h to see if the tag is listed explicitly. But this
is probably better.)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2022-07-06 10:40:10 | Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication |
| Previous Message | Peter Eisentraut | 2022-07-06 10:28:31 | Re: automatically generating node support functions |