| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: verify_heapam for sequences? |
| Date: | 2021-08-30 08:22:52 |
| Message-ID: | d1d2dcd7-3f4d-544e-3993-32a18290c095@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 26.08.21 21:02, Mark Dilger wrote:
> I understand that sequences are really just heap tables, and since we already test corrupted heap tables, we could assume that we already have sufficient coverage. I'm not entirely comfortable with that, though, because future patch authors who modify how tables or sequences work are not necessarily going to think carefully about whether their modifications invalidate that assumption.
Well, if we enabled verify_heapam to check sequences, and then someone
were to change the sequence storage, a test that currently reports no
corruption would probably report corruption then?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-08-30 08:35:37 | Re: Error code for checksum failure in origin.c |
| Previous Message | Peter Eisentraut | 2021-08-30 08:17:30 | Re: Some RELKIND macro refactoring |