Re: pgsql: Add Bloom filter implementation.

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add Bloom filter implementation.
Date: 2018-04-03 15:39:56
Message-ID: d1cc82ed-d07d-cef2-7c00-2e987f121648@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 3/31/18 21:36, Andres Freund wrote:
> Add Bloom filter implementation.

There is a compiler warning in the tests, with gcc-7:

test_bloomfilter.c: In function 'test_bloomfilter':
test_bloomfilter.c:40:38: error: '__builtin_snprintf' output may be
truncated before the last format character [-Werror=format-truncation=]
snprintf(element, sizeof(element), "i" INT64_FORMAT, i);
^

This can be fixed by allocating one more byte for the possible sign, or
doing the whole thing in unsigned.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Teodor Sigaev 2018-04-03 16:47:48 pgsql: Add prefix operator for TEXT type.
Previous Message Tom Lane 2018-04-03 15:33:27 Re: pgsql: Transforms for jsonb to PL/Perl