Re: pgsql: Use ICU by default at initdb time.

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: pgsql: Use ICU by default at initdb time.
Date: 2023-03-10 02:26:34
Message-ID: d191d5841347301a8f1238f609471ddd957fc47e.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, 2023-03-09 at 19:11 +0000, Jeff Davis wrote:
> Use ICU by default at initdb time.

I'm seeing a failure on hoverfly:

https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=hoverfly&dt=2023-03-09%2021%3A51%3A45&stg=initdb-en_US.8859-15

That's because ICU always uses UTF-8 by default. ICU works just fine
with many other encodings; is there a reason it doesn't take it from
the environment just like for provider=libc?

Of course, we still need to default to UTF-8 when the encoding from the
environment isn't supported by ICU.

Patch attached. Requires a few test fixups to adapt.

--
Jeff Davis
PostgreSQL Contributor Team - AWS

Attachment Content-Type Size
v1-0001-initdb-obtain-encoding-from-environment-by-defaul.patch text/x-patch 5.6 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2023-03-10 06:11:42 pgsql: Fix incorrect format placeholders
Previous Message Michael Paquier 2023-03-10 01:10:07 pgsql: pg_walinspect: pg_get_wal_fpi_info() -> pg_get_wal_block_info()

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2023-03-10 03:26:23 Re: Should vacuum process config file reload more often
Previous Message Melanie Plageman 2023-03-10 02:22:53 Re: Should vacuum process config file reload more often