| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Rosser Schwarz <rosser(dot)schwarz(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: add --if-exists to pg_recvlogical |
| Date: | 2017-09-19 20:12:00 |
| Message-ID: | d09676fd-8cae-3233-c882-4361038d38da@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/17/17 18:21, Rosser Schwarz wrote:
> On Fri, Sep 1, 2017 at 10:22 AM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com
> <mailto:peter(dot)eisentraut(at)2ndquadrant(dot)com>> wrote:
>> I understand the --drop-slot part. But I don't understand what it means
>> to ignore a missing replication slot when running --start.
>
> I'm not sure I do either, honestly. I followed the Principle of Least
> Surprise in making it a no-op when those switches are used and the slot
> doesn't exist, over "no one will ever do that". Because someone will.
>
> I'm happy to hear suggestions on what to do in that case beyond exit
> cleanly.
Nonsensical option combinations should result in an error.
It appears that you have removed the interaction of --start and
--if-exists in your last patch, but the documentation patch still
mentions it. Which is correct?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-19 20:16:33 | Re: Show backtrace when tap tests fail |
| Previous Message | Alexander Korotkov | 2017-09-19 20:03:04 | Re: Re: proposal - psql: possibility to specify sort for describe commands, when size is printed |