| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Krishnakumar R <kksrcv001(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Move bki file pre-processing from initdb to bootstrap |
| Date: | 2023-09-01 12:59:57 |
| Message-ID: | d07efce7-e6d1-4d94-fe52-9b977150e345@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01.09.23 14:37, Tom Lane wrote:
> Krishnakumar R <kksrcv001(at)gmail(dot)com> writes:
>> This patch moves the pre-processing for tokens in the bki file from
>> initdb to bootstrap. With these changes the bki file will only be
>> opened once in bootstrap and parsing will be done by the bootstrap
>> parser.
>
> You haven't provided any iota of evidence why this would be an
> improvement.
I had played with similar ideas in the past, because it would shave some
time of initdb, which would accumulate noticeably over a full test run.
But now with the initdb caching mechanism, I wonder whether this is
still needed.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-09-01 13:00:29 | Re: lockup in parallel hash join on dikkop (freebsd 14.0-current) |
| Previous Message | Peter Eisentraut | 2023-09-01 12:55:35 | Re: Commitfest 2023-09 starts soon |