Re: pg_combinebackup fails on file named INCREMENTAL.*

From: David Steele <david(at)pgmasters(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Subject: Re: pg_combinebackup fails on file named INCREMENTAL.*
Date: 2024-04-18 23:22:42
Message-ID: d052eded-9ef0-459a-a697-68d5f36d6977@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/19/24 01:10, Robert Haas wrote:
> On Wed, Apr 17, 2024 at 7:56 PM David Steele <david(at)pgmasters(dot)net> wrote:
>> Thanks! I've tested this and it works as advertised.
>>
>> Ideally I'd want an error on backup if there is a similar file in any
>> data directories that would cause an error on combine, but I admit that
>> it is vanishingly rare for users to put files anywhere but the root of
>> PGDATA, so this approach seems OK to me.
>
> OK, committed. Thanks for the review.

Excellent, thank you!

Regards,
-David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Koval 2024-04-18 23:26:07 Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Previous Message Michael Paquier 2024-04-18 23:20:18 Re: plenty code is confused about function level static