| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Amit Langote <amitlangote09(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] path toward faster partition pruning |
| Date: | 2018-03-13 17:54:45 |
| Message-ID: | d0411894-f6a7-7d54-af03-06c531d777cf@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Amit,
On 03/13/2018 07:37 AM, Amit Langote wrote:
> I will continue working on improving the comments / cleaning things up and
> post a revised version soon, but until then please look at the attached.
>
Passes check-world.
Some minor comments:
0001: Ok
0002: Ok
0003:
* Trailing white space
* pruning.c
- partkey_datum_from_expr
* "Add more expression types..." -- Are you planning to add more of
these ? Otherwise change the comment
- get_partitions_for_null_keys
* Documentation for method
* 'break;' missing for _HASH and default case
- get_partitions_for_keys
* 'break;'s are outside of the 'case' blocks
* The 'switch(opstrategy)'s could use some {} blocks
* 'break;' missing from default
- perform_pruning_combine_step
* Documentation for method
* nodeFuncs.c
- Missing 'break;'s to follow style
0004: Ok
Best regards,
Jesper
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-03-13 18:18:34 | Re: TupleTableSlot abstraction |
| Previous Message | Stephen Frost | 2018-03-13 17:50:03 | Re: PATCH: Configurable file mode mask |