| From: | Shinya Okano <btokanosn(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kasahara Tatsuhito <kasahara(dot)tatsuhito(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add a description to the documentation that toast_tuple_target affects "Main" |
| Date: | 2020-10-14 07:21:37 |
| Message-ID: | cfe3c1f5f0987c70ddde187d411739e3@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-10-14 01:30, Fujii Masao wrote:
> On 2020/10/13 10:40, Kasahara Tatsuhito wrote:
>> On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano
>> <btokanosn(at)oss(dot)nttdata(dot)com> wrote:
>>> Regarding the toast_tuple_target parameter of CREATE TABLE, the
>>> documentation says that it only affects External or Extended, but it
>>> actually affects the compression of Main as well.
>>>
>>> The attached patch modifies the document to match the actual
>>> behavior.
>> +1
>
> +1
>
> + we try to compress long column values or to move into TOAST
> tables, and
>
> "we try to compress and/or move long column values into TOAST tables,
> and" is better?
Thank you everyone for reviews.
I attached the new version of the patch.
Regards,
--
Shinya Okano
| Attachment | Content-Type | Size |
|---|---|---|
| V2-Add-Main-to-the-toast_tuple_target-doc.patch | text/x-diff | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-10-14 07:22:56 | Re: Remove some unnecessary if-condition |
| Previous Message | Luc Vlaming | 2020-10-14 07:13:42 | Re: Use list_delete_xxxcell O(1) instead of list_delete_ptr O(N) in some places |