| From: | Jose Arthur Benetasso Villanova <jose(dot)arthur(at)gmail(dot)com> |
|---|---|
| To: | Andrey Borodin <amborodin86(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Amcheck verification of GiST and GIN |
| Date: | 2022-12-14 12:18:44 |
| Message-ID: | cfa33a8e-de58-d5f1-7020-d0f01571a49d@benetasso.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 27 Nov 2022, Andrey Borodin wrote:
> On Sun, Nov 27, 2022 at 1:29 PM Andrey Borodin <amborodin86(at)gmail(dot)com> wrote:
>>
> I was wrong. GIN check does similar gin_refind_parent() to lock pages
> in bottom-up manner and truly verify downlink-child_page invariant.
Does this mean that we need the adjustment in docs?
> Here's v17. The only difference is that I added progress reporting to
> GiST verification.
> I still did not implement heapallindexed for GIN. Existence of pending
> lists makes this just too difficult for a weekend coding project :(
>
> Thank you!
>
> Best regards, Andrey Borodin.
>
I'm a bit lost here. I tried your patch again and indeed the
heapallindexed inside gin_check_parent_keys_consistency has a TODO
comment, but it's unclear to me if you are going to implement it or if the
patch "needs review". Right now it's "Waiting on Author".
--
Jose Arthur Benetasso Villanova
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amul Sul | 2022-12-14 12:35:02 | Re: Error-safe user functions |
| Previous Message | Amit Kapila | 2022-12-14 11:59:34 | Re: Force streaming every change in logical decoding |