| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Oid returned from AddSubscriptionRelState/UpdateSubscriptionRelState |
| Date: | 2018-10-01 13:25:34 |
| Message-ID: | cefdebe1-1c95-39ae-f683-164cfe852904@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 29/09/18 03:35, Andres Freund wrote:
>
> How come those two functions return oids, even though, as far as I
> understand, the underlying relation is BKI_WITHOUT_OIDS. I assume
> that's just an oversight?
>
Yeah, it's copy-pasto that managed to get through, those functions
should return void.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-return-value-of-subscription-relation-mapping-ma.patch | text/x-patch | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-10-01 13:29:18 | Re: Relations being opened without any lock whatever |
| Previous Message | John Naylor | 2018-10-01 13:19:21 | Re: Sync ECPG scanner with core |