Re: [PATCH] pg_test_fsync: close Windows alarm thread handles

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, harrisontbooth(at)gmail(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org, Sehrope Sarkuni <sehrope(at)jackdb(dot)com>
Subject: Re: [PATCH] pg_test_fsync: close Windows alarm thread handles
Date: 2026-10-15 09:36:12
Message-ID: cef4e14f-dba5-4e28-b3ab-024e20b72e46@iki.fi
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13/10/2026 19:05, Álvaro Herrera wrote:
> On 2026-Oct-13, harrisontbooth(at)gmail(dot)com wrote:
>
>> Attached is a follow-up to Sehrope's CF7218 timer fix - close each
>> created alarm-thread handle. Closing the handle leaves the callback
>> running.
>>
>> This is a dependent supplement. Apply the included CreateThread
>> failure-check prerequisite, then this patch, on master 8e82d6610e7.
>> The prerequisite credits Sehrope; it contains only his timer fix.
>
> Please don't start new threads just to propose a fix-up to some other
> proposed patch. Reply with your patch to the original thread instead.

This is actually a different bug, it just happens to touch the same
piece of code. Harrison, You did start a separate thread for a machine
review of the other patch though, so yeah, please don't do that.

Committed this one, thanks.

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2026-10-15 09:41:04 Re: Avoid repeated scans of the output buffer in oidvectortypes()
Previous Message Heikki Linnakangas 2026-10-15 09:35:36 Re: Assorted Win32 error handling fixes (CreateThread, pgwin32_select, pg_usleep)