| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Brar Piening <brar(at)gmx(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "Karl O(dot) Pinc" <kop(at)karlpinc(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: doc: add missing "id" attributes to extension packaging page |
| Date: | 2023-04-06 09:06:18 |
| Message-ID: | cea67271-ef9f-6c94-e303-bf9269ef6f35@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04.04.23 21:52, Brar Piening wrote:
>> The XSLT implementation looks sound to me. It would be a touch better
>> if it had some comments about which parts of the templates were copied
>> from upstream stylesheets and which were changed. There are examples
>> of such commenting in the existing customization layer. Also, avoid
>> introducing whitespace differences during said copying.
>
> I will amend the patch if we agree that this is the way forward.
Ok, it appears everyone agrees that this is the correct approach.
Please post an updated patch. There have been so many partial patches
posted recently, I'm not sure which one is the most current one and who
is really the author.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-04-06 09:11:57 | Re: meson documentation build open issues |
| Previous Message | Etsuro Fujita | 2023-04-06 08:41:41 | Re: postgres_fdw: commit remote (sub)transactions in parallel during pre-commit |