AppendStringInfoChar instead of appendStringInfoString

From: "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: AppendStringInfoChar instead of appendStringInfoString
Date: 2020-09-25 08:49:57
Message-ID: ce9a8564ccf1435eacf14bb7364ae9de@G08CNEXMBPEKD05.g08.fujitsu.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

In (/src/backend/replication/backup_manifest.c)

I found the following code:

appendStringInfoString(&buf, "\n");
appendStringInfoString(&buf, "\"");

Since only one bit string is appended here,
I think it will be better to call appendStringInfoChar.

Best reagrds,
houzj

Attachment Content-Type Size
0001-appendStringInfoChar-instead-of-appendStringInfoString.patch application/octet-stream 1.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message tsunakawa.takay@fujitsu.com 2020-09-25 08:55:03 RE: [Patch] Optimize dropping of relation buffers using dlist
Previous Message Masahiko Sawada 2020-09-25 08:35:05 Re: Transactions involving multiple postgres foreign servers, take 2