| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: postgres_fdw batching vs. (re)creating the tuple slots |
| Date: | 2021-06-11 21:01:56 |
| Message-ID: | cdff37d6-c57c-e40c-4635-4bcaeccd0d7d@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/9/21 1:08 PM, Tomas Vondra wrote:
>
>
> On 6/9/21 12:50 PM, Bharath Rupireddy wrote:
>> On Wed, Jun 9, 2021 at 4:00 PM Tomas Vondra
>> <tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
>>>
>>> Hi,
>>>
>>> Here's a v2 fixing a silly bug with reusing the same variable in two
>>> nested loops (worked for simple postgres_fdw cases, but "make check"
>>> failed).
>>
>> I applied these patches and ran make check in postgres_fdw contrib
>> module, I saw a server crash. Is it the same failure you were saying
>> above?
>>
>
> Nope, that was causing infinite loop. This is jut a silly mistake on my
> side - I forgot to replace the i/j variable inside the loop. Here's v3.
>
> regards
>
FWIW I've pushed this, after improving the comments a little bit.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-06-11 21:24:47 | Re: pg_stat_progress_create_index vs. parallel index builds |
| Previous Message | Robert Haas | 2021-06-11 20:57:05 | Re: Replication protocol doc fix |