| From: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | kuroda(dot)hayato(at)fujitsu(dot)com, Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: make the stats collector shutdown without writing the statsfiles if the immediate shutdown is requested. |
| Date: | 2021-03-25 00:32:29 |
| Message-ID: | cd7f0f68-a793-c5a4-51d7-22b877a42421@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/03/24 18:36, Fujii Masao wrote:
> On 2021/03/23 15:50, Fujii Masao wrote:
>> + * The statistics collector is started by the postmaster as soon as the
>> + * startup subprocess finishes.
>>
>> This comment needs to be updated? Because the stats collector can
>> be invoked when the startup process sends PMSIGNAL_BEGIN_HOT_STANDBY
>> signal.
>
> I updated this comment in the patch.
> Attached is the updated version of the patch.
>
> Barring any objection, I'm thinking to commit this patch.
Thanks for your comments and updating the patch!
I checked your patch and I don't have any comments.
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-03-25 00:58:25 | Re: make the stats collector shutdown without writing the statsfiles if the immediate shutdown is requested. |
| Previous Message | Masahiro Ikeda | 2021-03-25 00:31:46 | Re: make the stats collector shutdown without writing the statsfiles if the immediate shutdown is requested. |