Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg

From: Vlad <marchenko(at)gmail(dot)com>
To: Brandon Metcalf <bmetcalf(at)nortel(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, dbdpg-general(at)gborg(dot)postgresql(dot)org, pgsql-interfaces(at)postgresql(dot)org
Subject: Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg
Date: 2005-04-08 20:24:17
Message-ID: cd70c68105040813249ec7813@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-interfaces

Brandon,

try this patch instead.

diff -ru DBD-Pg-1.41/dbdimp.c DBD-Pg-1.41-patched/dbdimp.c
--- DBD-Pg-1.41/dbdimp.c Fri Apr 8 16:06:12 2005
+++ DBD-Pg-1.41-patched/dbdimp.c Fri Apr 8 15:46:50 2005
@@ -1415,7 +1415,7 @@
}
else if (NULL == currph->bind_type) { /* "sticky" data type */
/* This is the default type, but we will honor
defaultval if we can */
- currph->bind_type = pg_type_data(VARCHAROID);
+ currph->bind_type = pg_type_data(UNKNOWNOID);
if (!currph->bind_type)
croak("Default type is bad!!!!???");
}
diff -ru DBD-Pg-1.41/types.c DBD-Pg-1.41-patched/types.c
--- DBD-Pg-1.41/types.c Fri Apr 8 16:06:23 2005
+++ DBD-Pg-1.41-patched/types.c Fri Apr 8 15:46:37 2005
@@ -55,7 +55,7 @@
{ABSTIMEOID, "abstime", DBDPG_TRUE, null_quote, null_dequote, {0}},
{RELTIMEOID, "reltime", DBDPG_TRUE, null_quote, null_dequote, {0}},
{TINTERVALOID, "tinterval", DBDPG_TRUE, null_quote, null_dequote, {0}},
- {UNKNOWNOID, "unknown", DBDPG_FALSE, null_quote, null_dequote, {0}},
+ {UNKNOWNOID, "unknown", DBDPG_FALSE, quote_varchar, null_dequote, {0}},
{CIRCLEOID, "circle", DBDPG_FALSE, null_quote, null_dequote, {0}},
{CASHOID, "money", DBDPG_TRUE, null_quote, null_dequote, {0}},
{MACADDROID, "MAC address", DBDPG_TRUE,
quote_varchar,dequote_varchar, {0}},

On Apr 8, 2005 4:14 PM, Brandon Metcalf <bmetcalf(at)nortel(dot)com> wrote:
> m == marchenko(at)gmail(dot)com writes:
>
> m> --- dbdimp.c.bak Wed Apr 6 16:40:20 2005
> m> +++ dbdimp.c Fri Apr 8 15:21:29 2005
> m> @@ -1415,7 +1415,7 @@
> m> }
> m> else if (NULL == currph->bind_type) { /* "sticky" data type */
> m> /* This is the default type, but we will honor
> m> defaultval if we can */
> m> - currph->bind_type = pg_type_data(VARCHAROID);
> m> + currph->bind_type = pg_type_data(UNKNOWNOID);
> m> if (!currph->bind_type)
> m> croak("Default type is bad!!!!???");
> m> }
>
> Using this patch results in error messages like:
>
> DBD::Pg::st execute failed: ERROR: syntax error at or near "15" at character 158
>
> Not sure why yet.
>
> --
> Brandon
>

--
Vlad

In response to

Responses

Browse pgsql-interfaces by date

  From Date Subject
Next Message Tom Lane 2005-04-08 20:41:37 Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg
Previous Message Brandon Metcalf 2005-04-08 20:14:53 Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg