| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: queryId constant squashing does not support prepared statements |
| Date: | 2025-05-12 08:15:59 |
| Message-ID: | cd4ouhwxlxb3yrq2l6cdhlckhu6qhens4unfakvruht2f56rn6@ey24svyxxo4k |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Fri, May 09, 2025 at 12:47:19PM GMT, Sami Imseih wrote:
> So, I think we can create a new parse node ( parsenode.h ) that will only be
> used in parsing (and gram.c only ) to track the start/end locations
> and List and
> based on this node we can create A_ArrayExpr and A_Expr with the List
> of boundaries,
> and then all we have to do is update ArrayExpr with the boundaries during
> the respective transformXExpr call. This seems like a much simpler approach
> that also addresses Michael's concern of defining static variables in gram.y to
> track the boundaries.
The static variables was only part of the concern, another part was
using A_Expr to carry this information, which will have impact on lots
of unrelated code.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-05-12 08:27:41 | Re: add tab-complete for ALTER DOMAIN ADD... |
| Previous Message | Dmitry Dolgov | 2025-05-12 08:11:15 | Re: queryId constant squashing does not support prepared statements |