Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruno Wolff III <bruno(at)wolff(dot)to>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS
Date: 2017-06-21 02:12:51
Message-ID: cd372b5a-bda9-6d9e-8310-e60e77ef0ee3@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2017/06/21 11:02, Alvaro Herrera wrote:
> Bruno Wolff III wrote:
>> I'm not seeing an obvious error in my attempt to use CREATE STATISTICS IF
>> NOT EXISTS. Given this is new, maybe there is a bug in the parser.
>
> You're absolutely right, and this is a bug in the parser -- I probably
> misplaced the IF NOT EXISTS clause while playing with Tomas' parser
> changes. Here's the fix. I'm a bit troubled that this change doesn't
> seem to affect any tests, so I'll add some before pushing.

I posted the same patch but with a test:

https://www.postgresql.org/message-id/38b7d52e-387a-0e47-7525-b8b654ca4bfb%40lab.ntt.co.jp

Forgot to cc you or Tomas.

Thanks,
Amit

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Ahsan Hadi 2017-06-21 05:50:33 Re: BUG #14709: inconsistent answers with foreign data wrappers to mysql
Previous Message Alvaro Herrera 2017-06-21 02:02:10 Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-06-21 02:20:26 Broken link to DocBook XSL Stylesheets
Previous Message Alvaro Herrera 2017-06-21 02:02:10 Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS