Re: SQL/JSON: functions

From: Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Erik Rijkers <er(at)xs4all(dot)nl>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andrew Alsup <bluesbreaker(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)postgrespro(dot)ru>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Michael Paquier <michael(at)paquier(dot)xyz>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Subject: Re: SQL/JSON: functions
Date: 2020-03-17 00:55:06
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Attached 44th version of the patches.

On 12.03.2020 16:41, Pavel Stehule wrote:
> On 12.03.2020 00:09 Nikita Glukhov wrote:
> Attached 43rd version of the patches.
> The previous patch #4 ("Add function formats") was removed.
> Instead, introduced new executor node JsonCtorExpr which is used to wrap
> SQL/JSON constructor function calls (FuncExpr, Aggref, WindowFunc).
> Also, JsonIsPredicate node began to be used as executor node.
> This helped to remove unnecessary json[b]_is_valid() user functions.
> It looks very well - all tests passed, code looks well.
> Now, when there are special nodes, then the introduction of
> COERCE_INTERNAL_CAST is not necessary, and it is only my one and last
> objection again this patch's set.
I have removed patch #3 with COERCE_INTERNAL_CAST too.

Coercions in JsonValueExpr in JsonCtorExpr, which were previously hidden with
clauses, now moved into separate expressions.

User functions json[b]_build_object_ext() and json[b]_build_array_ext() also
can be easily removed. But it seems harder to remove new aggregate functions
json[b]_objectagg() and json[b]_agg_strict(), because they can't be called
directly from JsonCtorExpr node.

The support for json type in jsonpath also seems to be immature, so I will try
to remove it in the next iteration.

Nikita Glukhov
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
0001-Jsonpath-support-for-json-v44.patch.gz application/gzip 43.6 KB
0002-Add-common-SQL-JSON-clauses-v44.patch.gz application/gzip 7.5 KB
0003-SQL-JSON-constructors-v44.patch.gz application/gzip 30.4 KB
0004-IS-JSON-predicate-v44.patch.gz application/gzip 12.6 KB
0005-SQL-JSON-query-functions-v44.patch.gz application/gzip 39.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2020-03-17 00:58:51 Re: Adding missing object access hook invocations
Previous Message Thomas Munro 2020-03-17 00:19:23 Re: Parallel leader process info in EXPLAIN