From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs |
Date: | 2023-09-26 10:48:17 |
Message-ID: | ccf39484-54cc-5efc-3abb-337b0875372f@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 25.09.23 12:56, Nazir Bilal Yavuz wrote:
> + # Only run if a specific OS is not requested and if there are changes in docs
> + # or in the CI files.
> + skip: >
> + $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:.*' ||
> + !changesInclude('doc/**',
> + '.cirrus.yml',
> + '.cirrus.tasks.yml',
> + 'src/backend/catalog/sql_feature_packages.txt',
> + 'src/backend/catalog/sql_features.txt',
> + 'src/backend/utils/errcodes.txt',
> + 'src/backend/utils/activity/wait_event_names.txt',
> + 'src/backend/utils/activity/generate-wait_event_types.pl',
> + 'src/include/parser/kwlist.h')
This is kind of annoying. Now we need to maintain yet another list of
these dependencies and keep it in sync with the build systems.
I think meson can produce a dependency tree from a build. Maybe we
could use that somehow and have Cirrus cache it between runs?
Also note that there are also dependencies in the other direction. For
example, the psql help is compiled from XML DocBook sources. So your
other patch would also need to include similar changesInclude() clauses.
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2023-09-26 11:12:57 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |
Previous Message | Ashutosh Bapat | 2023-09-26 10:34:36 | Re: Avoid a possible out-of-bounds access (src/backend/optimizer/util/relnode.c) |