| From: | Kartyshov Ivan <i(dot)kartyshov(at)postgrespro(dot)ru> |
|---|---|
| To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Cc: | Anna Akenteva <a(dot)akenteva(at)postgrespro(dot)ru>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Subject: | Re: [HACKERS] make async slave to wait for lsn to be replayed |
| Date: | 2020-04-07 23:14:48 |
| Message-ID: | ccdc6c31218f61a2970c84cc850c8a41@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-04-08 00:27, Tom Lane wrote:
> Alexander Korotkov <akorotkov(at)postgresql(dot)org> writes:
» WAIT FOR LSN lsn [ TIMEOUT timeout ]
>
> This seems like a really carelessly chosen syntax —- *three* new
> keywords, when you probably didn't need any. Are you not aware that
> there is distributed overhead in the grammar for every keyword?
> Plus, each new keyword carries the risk of breaking existing
> applications, since it no longer works as an alias-not-preceded-by-AS.
>
To avoid creating new keywords, we could change syntax in the following
way:
WAIT FOR => DEPENDS ON
LSN => EVENT
TIMEOUT => WITH INTERVAL
So
START TRANSACTION WAIT FOR LSN '0/3F07A6B1' TIMEOUT 5000;
would instead look as
START TRANSACTION DEPENDS ON EVENT '0/3F07A6B1' WITH INTERVAL '5
seconds';
[1]
https://www.postgresql.org/message-id/28209.1586294824%40sss.pgh.pa.us
--
Ivan Kartyshov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-04-07 23:26:02 | Re: pgsql: Allow users to limit storage reserved by replication slots |
| Previous Message | Peter Geoghegan | 2020-04-07 23:02:22 | Re: Using the rr debugging tool to debug Postgres |