Re: Allow CURRENT_ROLE in GRANTED BY

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: Allow CURRENT_ROLE in GRANTED BY
Date: 2020-08-26 11:00:57
Message-ID: cc12f3fc-9fb1-71dc-1b51-1edf65f9e5c2@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-06-29 14:47, Peter Eisentraut wrote:
> On 2020-06-24 23:08, Alvaro Herrera wrote:
>> On 2020-Jun-24, Peter Eisentraut wrote:
>>
>>> I was checking some loose ends in SQL conformance, when I noticed: We
>>> support GRANT role ... GRANTED BY CURRENT_USER, but we don't support
>>> CURRENT_ROLE in that place, even though in PostgreSQL they are equivalent.
>>> Here is a trivial patch to add that.
>>
>> Hmm, since this adds to RoleSpec, this change makes every place that
>> uses that production also take CURRENT_ROLE, so we'd need to document in
>> all those places. For example, alter_role.sgml, create_schema.sgml,
>> etc.
>
> Good point. Here is an updated patch that updates all the documentation
> places where CURRENT_USER is mentioned.

Here is another patch that also makes comprehensive updates to the
rolenames tests under src/test/modules/unsafe_tests/.

I think this should now cover all the required ancillary changes.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
v3-0001-Allow-CURRENT_ROLE-where-CURRENT_USER-is-accepted.patch text/plain 114.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2020-08-26 11:13:22 Re: use pg_get_functiondef() in pg_dump
Previous Message Amit Kapila 2020-08-26 10:50:49 Re: Implement UNLOGGED clause for COPY FROM