| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: invalid data in file backup_label problem on windows |
| Date: | 2021-03-18 16:39:06 |
| Message-ID: | cc035f09-ef7b-0270-f8bc-e895507ffa34@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/14/21 10:50 PM, Wang, Shenhao wrote:
>
>> Please feel free to, under the section "Bug fixes". This way, it
>> won't get lost in the traffic of this list.
>> --
>> Michael
>
> Thank you for your advise, added it
I'm not sure how I feel about this patch (not really a Windows person)
but I do think that you shouldn't modify the backup_label when writing
it, i.e. you should be writing backup_label in binary mode to avoid this
issue.
No objections from me if it gets committed but I'm not sure it should be
classified as a "bug fix" since the backup_label was modified from what
postgres provided, unless I am misunderstanding.
Regards,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2021-03-18 16:40:22 | Re: cleanup temporary files after crash |
| Previous Message | Peter Geoghegan | 2021-03-18 16:38:05 | Re: a verbose option for autovacuum |