From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: fairywren hung in pg_basebackup tests |
Date: | 2022-07-25 16:02:57 |
Message-ID: | cbf0259a-036f-da1f-4cb8-530b1f28cafb@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2022-07-25 Mo 11:24, Thomas Munro wrote:
> On Tue, Jul 26, 2022 at 3:08 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I wrote:
>>> Right, so the "glob" failed to find anything. Seeing that this test
>>> is new as of 534472375, which postdates fairywren's last successful
>>> run, I'd guess that the "glob" needs adjustment for msys path names.
> The test added by 534472375 is at the end, hundreds of lines later
> than the one that appears to be failing.
Right.
>
>> Hmm ... an alternative theory is that the test is fine, and what
>> it's telling us is that get_dirent_type() is still wrong on msys.
>> Would that end in this symptom?
> Hmm, possibly yes (if it sees a non-symlink, it'll skip it). If
> someone can run the test on an msys system, perhaps they could put a
> debugging elog() into the code modified by 9d3444dc to log d_name and
> the d_type that is returned? I'm struggling to understand why msys
> would change the answer though.
I have no idea either. The link exists and it is a junction. I'll see
about logging details.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2022-07-25 16:06:28 | Re: log_line_prefix: make it possible to add the search_path |
Previous Message | Fujii Masao | 2022-07-25 15:54:47 | Refactoring postgres_fdw/connection.c |