From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | genbki stricter error handling |
Date: | 2021-06-23 09:26:50 |
Message-ID: | ca8ee41d-241b-1bf3-71f0-aaf1add6d3c5@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
genbki.pl says:
# Perform OID lookups on an array of OID names.
# If we don't have a unique value to substitute, warn and
# leave the entry unchanged.
# (A warning seems sufficient because the bootstrap backend will reject
# non-numeric values anyway. So we might as well detect multiple problems
# within this genbki.pl run.)
This is fine, but I have found this to be a bit cumbersome in practice
sometimes, because errors are then not easily seen at build time but
have to be extracted from some log files during test runs.
I propose the attached patch to make genbki.pl error out if it
encounters any errors in this routine, while preserving the property
that all errors in one run are reported.
Attachment | Content-Type | Size |
---|---|---|
0001-genbki-stricter-error-handling.patch | text/plain | 2.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fabien COELHO | 2021-06-23 09:37:58 | Re: pgbench logging broken by time logic changes |
Previous Message | houzj.fnst@fujitsu.com | 2021-06-23 09:26:36 | RE: Deadlock risk while inserting directly into partition? |