| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net> |
| Cc: | Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, Darafei Praliaskouski <me(at)komzpa(dot)net>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Cast jsonb to numeric, int, float, bool |
| Date: | 2018-03-27 15:09:17 |
| Message-ID: | ca0bdf99-98a5-3a44-3f49-13941e0634ca@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
I took a look on patch and it seems to me it looks both incomplete and
oveflowing. It suggests cast from numeric and bool, but for numeric it suggests
only numeric, int4 and int8. This choice looks irrational.
I think, it should support from/to numeric/bool/text only. If we want to have
casts to from numeric to other numeric types then it should be full set (int2,
int4, int8, float4, float8).
Aleksander Alekseev wrote:
> Hello everyone,
>
>> Since this patch was updated after being set a Ready for Committer and
>> there appear to be some open questions, I have set it to Needs Review.
>
> I decided to take a look.
>
> The patch didn't apply after changes made in fd1a421f, but I fixed that.
> Also there were no tests. I fixed that too.
>
> I believe it's "Ready for Committer".
>
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Glukhov | 2018-03-27 15:13:11 | Re: jsonpath |
| Previous Message | Tom Lane | 2018-03-27 14:58:14 | Re: Parallel Aggregates for string_agg and array_agg |