From: | "Erik Rijkers" <er(at)xs4all(dot)nl> |
---|---|
To: | "David Rowley" <dgrowleyml(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] Negative Transition Aggregate Functions (WIP) |
Date: | 2014-01-02 12:36:56 |
Message-ID: | ca0b2fb148fd69b700fa8c6f047cb9cc.squirrel@webmail.xs4all.nl |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, January 2, 2014 13:05, David Rowley wrote:
> here's a slightly updated patch
> [inverse_transition_functions_v1.8.patch.gz ]
patch applies, and compiles (although with new warnings).
But make check complains loudly: see attached.
warnings:
In file included from gram.y:13871:0:
scan.c: In function â:
scan.c:10167:23: warning: unused variable â [-Wunused-variable]
struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; /* This var may be unused depending upon options. */
^
In file included from ../../../../src/include/utils/probes.h:6:0,
from ../../../../src/include/pg_trace.h:15,
from tuplesort.c:109:
tuplesort.c: In function â:
tuplesort.c:935:44: warning: comparison between pointer and integer [enabled by default]
TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);
^
tuplesort.c:935:2: note: in expansion of macro â
TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);
I didn't yet use the patch you sent after this patch.
Thanks,
Erik Rijkers
Attachment | Content-Type | Size |
---|---|---|
regression.out | application/octet-stream | 7.4 KB |
regression.diffs | application/octet-stream | 636.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-01-02 12:40:18 | Re: preserving forensic information when we freeze |
Previous Message | Robert Haas | 2014-01-02 12:35:11 | Re: preserving forensic information when we freeze |