| From: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Ahsan Hadi <ahsan(dot)hadi(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Soumyadeep Chakraborty <soumyadeep2007(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add session statistics to pg_stat_database |
| Date: | 2020-12-25 11:28:06 |
| Message-ID: | c93cbb71109c7c0465ce3541a9ec98ad@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
As a user, I want this feature to know whether
clients' session activities are as expected.
I have some comments about the patch.
1. pg_proc.dat
The unit of "session time" and so on says "in seconds".
But, is "in milliseconds" right?
2. monitoring.sgml
IIUC, "active_time" includes the time executes a fast-path function and
"idle in transaction" includes "idle in transaction(aborted)" time.
Why don't you reference pg_stat_activity's "state" column and
"active_time" is the total time when the state is "active" and "fast
path"?
"idle in transaction" is as same too.
3. pgstat.h
The comment of PgStat_MsgConn says "Sent by pgstat_connection".
I thought "pgstat_connection" is a function, but it doesn't exist.
Is "Sent by the backend" right?
Although this is a trivial thing, the following row has too many tabs.
Other structs have only one space.
// }<tab><tab><tab>Pgstat_MsgConn;
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2020-12-25 12:12:50 | Re: Logical decoding without slots: decoding in lockstep with recovery |
| Previous Message | osumi.takamichi@fujitsu.com | 2020-12-25 11:27:12 | RE: Disable WAL logging to speed up data loading |