Re: [PING] [PATCH v2] parallel pg_restore: avoid disk seeks when jumping short distance forward

From: Dimitrios Apostolou <jimis(at)gmx(dot)net>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PING] [PATCH v2] parallel pg_restore: avoid disk seeks when jumping short distance forward
Date: 2025-06-10 22:32:58
Message-ID: c8d94212-72cc-cd9f-162f-8eb845ba104f@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 10 Jun 2025, Nathan Bossart wrote:

> I also wrote a couple of test programs to show the difference between
> fseeko-ing and fread-ing through a file with various sizes. On a Linux
> machine, I see this:
>
> log2(n) | fseeko | fread
> ---------+---------+-------
> 1 | 109.288 | 5.528
> 2 | 54.881 | 2.848
> 3 | 27.65 | 1.504
> 4 | 13.953 | 0.834
> 5 | 7.1 | 0.49
> 6 | 3.665 | 0.322
> 7 | 1.944 | 0.244
> 8 | 1.085 | 0.201
> 9 | 0.658 | 0.185
> 10 | 0.443 | 0.175
> 11 | 0.253 | 0.171
> 12 | 0.102 | 0.162
> 13 | 0.075 | 0.13
> 14 | 0.061 | 0.114
> 15 | 0.054 | 0.1
>
> So, fseeko() starts winning around 4096 bytes. On macOS, the differences
> aren't quite as dramatic, but 4096 bytes is the break-even point there,
> too. I imagine there's a buffer around that size somewhere...

Thank you for benchmarking! Before answering in more depth, I'm curious,
what read-seek pattern do you see on the system call level (as
shown by strace)? In pg_restore it was a constant loop of
read(4K)-lseek(8-16K).

Dimitris

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-06-10 22:34:05 Re: Cleanup gcc trick with varattrib_1b_e in VARATT_EXTERNAL_GET_POINTER()
Previous Message Peter Smith 2025-06-10 22:22:46 Re: [WIP]Vertical Clustered Index (columnar store extension) - take2