| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Cleanup gcc trick with varattrib_1b_e in VARATT_EXTERNAL_GET_POINTER() |
| Date: | 2025-06-10 22:34:05 |
| Message-ID: | aEiy3V8dnjkHA3aD@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 10, 2025 at 06:30:33PM +0200, Peter Eisentraut wrote:
> I can see how this might have been different historically. I have noticed
> that there are some areas of code where Datum and struct varlena * or
> similar are used interchangeably. Macros tend to hide that kind of
> confusion. But some of this has been cleaned up with changing some macros
> to inline functions. Maybe doing the same would help here, too.
Yeah, I've noticed that some code paths tend to be a bit confused
about both concepts, sticking to one while silently assuming the
other. Perhaps these could be made cleaner.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-06-10 22:56:43 | Re: Cleanup gcc trick with varattrib_1b_e in VARATT_EXTERNAL_GET_POINTER() |
| Previous Message | Dimitrios Apostolou | 2025-06-10 22:32:58 | Re: [PING] [PATCH v2] parallel pg_restore: avoid disk seeks when jumping short distance forward |