| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: FOR EACH ROW triggers on partitioned tables |
| Date: | 2018-03-22 16:27:00 |
| Message-ID: | c847c761-dd14-9ea9-5aaa-1d3cf9606dd8@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/21/18 19:18, Alvaro Herrera wrote:
> Here's v8, which addresses all your comments except the doc updates. I
> added a few more tests, too. Thanks for the review! I intend to commit
> this shortly, probably not before Friday to give some more time for
> others to review/comment.
Looks good, does what it needs to do.
A small fixup attached. In particular, I renamed one trigger from "f",
which created confusing output, looking like a boolean column.
This comment in the tests I don't understand:
-- verify that the FOR UPDATE OF (columns) is propagated correctly
I don't see how this applies to the tests that follow. Does this have
something to do with the subsequent foreign keys patch perhaps?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-fixup-Allow-FOR-EACH-ROW-triggers-on-partitioned-tab.patch | text/plain | 6.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2018-03-22 16:38:38 | Re: Using base backup exclusion filters to reduce data transferred with pg_rewind |
| Previous Message | David Steele | 2018-03-22 16:22:31 | Re: [PATCH] Verify Checksums during Basebackups |