| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: FOR EACH ROW triggers on partitioned tables |
| Date: | 2018-03-22 16:40:23 |
| Message-ID: | 20180322164023.yhcxcqi5alzfqguh@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> On 3/21/18 19:18, Alvaro Herrera wrote:
> > Here's v8, which addresses all your comments except the doc updates. I
> > added a few more tests, too. Thanks for the review! I intend to commit
> > this shortly, probably not before Friday to give some more time for
> > others to review/comment.
>
> Looks good, does what it needs to do.
>
> A small fixup attached. In particular, I renamed one trigger from "f",
> which created confusing output, looking like a boolean column.
Thanks!
> This comment in the tests I don't understand:
>
> -- verify that the FOR UPDATE OF (columns) is propagated correctly
>
> I don't see how this applies to the tests that follow. Does this have
> something to do with the subsequent foreign keys patch perhaps?
Not at all ... I meant "AFTER UPDATE OF columns" (used as a firing
event). Not sure how I typo'ed it that badly.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2018-03-22 16:57:34 | Re: [HACKERS] Surjective functional indexes |
| Previous Message | Fujii Masao | 2018-03-22 16:38:38 | Re: Using base backup exclusion filters to reduce data transferred with pg_rewind |