Re: appendBinaryStringInfo stuff

On 10.02.23 20:08, Corey Huinker wrote:
>
>
> On Fri, Feb 10, 2023 at 7:16 AM Peter Eisentraut
> <peter(dot)eisentraut(at)enterprisedb(dot)com
> <mailto:peter(dot)eisentraut(at)enterprisedb(dot)com>> wrote:
>
> On 19.12.22 07:13, Peter Eisentraut wrote:
> > Also, the argument type of appendBinaryStringInfo() is char *.
> There is
> > some code that uses this function to assemble some kind of packed
> binary
> > layout, which requires a bunch of casts because of this.  I think
> > functions taking binary data plus length should take void * instead,
> > like memcpy() for example.
>
> I found a little follow-up for this one: Make the same change to
> pq_sendbytes(), which is a thin wrapper around
> appendBinaryStringInfo().
>   This would allow getting rid of further casts at call sites.
>
>
> +1
>
> Has all the benefits that 54a177a948b0a773c25c6737d1cc3cc49222a526 had.
>
> Passes make check-world.

committed, thanks