| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Hugo Zhang <hugo(dot)zhang(at)openpie(dot)com> |
| Subject: | Re: Useless parameter 'cur_skey' in IndexScanOK |
| Date: | 2024-08-16 10:28:57 |
| Message-ID: | c7f54813-a816-4584-9040-0dea91fdbb4c@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/07/2024 16:46, Daniel Gustafsson wrote:
>> On 3 Jul 2024, at 15:41, Aleksander Alekseev <aleksander(at)timescale(dot)com> wrote:
>>> The 'cur_skey' parameter in `IndexScanOK` funciton doesn't seem to be useful.
>
>> Good catch. As I understand it is not used for anything since
>> a78fcfb51243 (dated 2006) and this is a static function, so we
>> shouldn't worry about third-party extensions.
>
> Agreed, it seems reasonable to clean this up.
>
>> I wonder why none of the compilers complained about this.
>
> Not to mention static analyzers.
Committed, thanks.
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo Nagata | 2024-08-16 10:32:24 | Re: [PATCH] Add get_bytes() and set_bytes() functions |
| Previous Message | Michail Nikolaev | 2024-08-16 10:22:00 | Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY |