From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Sergei Agalakov <sergei(dot)agalakov(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: explain plans with information about (modified) gucs |
Date: | 2019-01-15 01:39:49 |
Message-ID: | c76b7ec7-70db-6ec9-cc1a-73ffb53f6b2e@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 1/14/19 11:13 PM, Alvaro Herrera wrote:
> On 2019-Jan-14, Tomas Vondra wrote:
>
>> The one slightly annoying issue is that currently all the options are
>> formatted as text, including e.g. cpu_tuple_cost. That's because the GUC
>> options may have show hook, so I can't access the value directly (not
>> sure if there's an option around it).
>
> I think the problem is that you'd have to know how to print the value,
> which can be in one of several different C types. You'd have to grow
> some more infrastructure in the GUC tables, I think, and that doesn't
> seem worth the trouble. Printing as text seems enough.
>
I don't think the number of formats is such a big issue - the range of
formats is quite limited: PGC_BOOL, PGC_INT, PGC_REAL, PGC_STRING and
PGC_ENUM. But the show hook simply returns string, and I'm not sure it's
guaranteed it matches the raw value (afaik the assign/show hooks can do
all kinds of funny stuff).
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2019-01-15 01:46:34 | Re: Query with high planning time at version 11.1 compared versions 10.5 and 11.0 |
Previous Message | Andres Freund | 2019-01-15 01:22:07 | Re: Reducing header interdependencies around heapam.h et al. |