| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_upgrade should truncate/remove its logs before running |
| Date: | 2021-12-16 11:11:25 |
| Message-ID: | c7615cf3-621a-7fc4-79ec-6b2554cd5b68@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16.12.21 02:39, Michael Paquier wrote:
> On Wed, Dec 15, 2021 at 04:13:10PM -0600, Justin Pryzby wrote:
>> On Wed, Dec 15, 2021 at 05:04:54PM -0500, Andrew Dunstan wrote:
>>> The directory name needs to be predictable somehow, or maybe optionally
>>> set as a parameter. Having just a timestamped directory name would make
>>> life annoying for a poor buildfarm maintainer. Also, please don't change
>>> anything before I have a chance to adjust the buildfarm code to what is
>>> going to be done.
>>
>> Feel free to suggest the desirable behavior.
>> It could write to pg_upgrade.log/* and refuse to run if the dir already exists.
>
> Andrew's point looks rather sensible to me. So, this stuff should
> have a predictable name (pg_upgrade.log, pg_upgrade_log or upgrade_log
> would be fine). But I would also add an option to be able to define a
> custom log path. The latter would be useful for the regression tests
> so as everything gets could get redirected to a path already filtered
> out.
Could we make it write just one log file? Is having multiple log files
better?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-12-16 11:23:08 | Re: pg_upgrade should truncate/remove its logs before running |
| Previous Message | Ronan Dunklau | 2021-12-16 10:56:15 | Re: Use generation context to speed up tuplesorts |