| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: Making Bitmapsets be valid Nodes |
| Date: | 2022-11-13 12:22:33 |
| Message-ID: | c75f3004-5257-56b3-6717-09560ef92a2b@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11.11.22 21:05, Tom Lane wrote:
> Per the discussion at [1], it seems like it'd be a good idea to make
> Bitmapsets into full-fledged, tagged Nodes, so that we could do things
> like print or copy lists of them without special-case logic. The
> extra space for the NodeTag is basically free due to alignment
> considerations, at least on 64-bit hardware.
>
> Attached is a cleaned-up version of Amit's patch v24-0003 at [2].
> I fixed the problems with not always tagging Bitmapsets, and changed
> the outfuncs/readfuncs logic so that Bitmapsets still print exactly
> as they did before (thus, this doesn't require a catversion bump).
This looks good to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2022-11-13 14:58:34 | Re: Schema variables - new implementation for Postgres 15 |
| Previous Message | Laurenz Albe | 2022-11-13 11:56:30 | Re: New docs chapter on Transaction Management and related changes |