Re: Bug in get_partition_for_tuple

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug in get_partition_for_tuple
Date: 2017-03-13 05:41:13
Message-ID: c72cbc58-9866-0622-86c1-f01cc4064e73@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Jeevan,

On 2017/03/13 14:31, Jeevan Ladhe wrote:
> Hi Amit,
>
> I was able to reproduce the crash, and with the attached patch the crash
> goes
> away. Also, "make check-world" passes clean.
>
> Patch looks good to me.

Thanks for the review.

> However, In following comment in your test:
>
> -- check routing error through a list partitioned table when they key is
> null
>
> I think you want to say:
>
> -- check routing error through a list partitioned table when the key is null

You're right, fixed that in the attached updated patch.

Thanks,
Amit

Attachment Content-Type Size
0001-Fix-a-bug-in-get_partition_for_tuple.patch text/x-diff 3.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Sharma 2017-03-13 05:46:03 Re: Page Scan Mode in Hash Index
Previous Message Jeevan Ladhe 2017-03-13 05:31:16 Re: Bug in get_partition_for_tuple