| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Steve Singer <steve(at)ssinger(dot)info>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: Logical Replication WIP |
| Date: | 2016-12-12 14:18:48 |
| Message-ID: | c7236ac8-b106-4b6c-72d0-fb127f339804@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/8/16 4:10 PM, Petr Jelinek wrote:
> On 08/12/16 20:16, Peter Eisentraut wrote:
>> On 12/6/16 11:58 AM, Peter Eisentraut wrote:
>>> On 12/5/16 6:24 PM, Petr Jelinek wrote:
>>>> I think that the removal of changes to ReplicationSlotAcquire() that you
>>>> did will result in making it impossible to reacquire temporary slot once
>>>> you switched to different one in the session as the if (active_pid != 0)
>>>> will always be true for temp slot.
>>>
>>> I see. I suppose it's difficult to get a test case for this.
>>
>> I created a test case, saw the error of my ways, and added your code
>> back in. Patch attached.
>>
>
> Hi,
>
> I am happy with this version, thanks for moving it forward.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2016-12-12 14:21:55 | Re: [COMMITTERS] pgsql: Add support for temporary replication slots |
| Previous Message | Peter Eisentraut | 2016-12-12 14:16:34 | pgsql: Add support for temporary replication slots |