| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net> |
| Cc: | Antonin Houska <ah(at)cybertec(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [PATCH] Incremental sort |
| Date: | 2018-03-28 13:44:56 |
| Message-ID: | c657780f-4504-9c43-edb2-d5cb6f560076@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/28/2018 03:28 PM, Teodor Sigaev wrote:
>> BTW, patch had conflicts with master. Please, find rebased version
>> attached.
>
> Despite by patch conflist patch looks commitable, has anybody objections
> to commit it?
>
> Patch recieved several rounds of review during 2 years, and seems to me,
> keeping it out from sources may cause a lost it. Although it suggests
> performance improvement in rather wide usecases.
>
No objections from me - if you want me to do one final round of review
after the rebase (not sure how invasive it'll turn out), let me know.
BTW one detail I'd change is name of the GUC variable. enable_incsort
seems unnecessarily terse - let's go for enable_incremental_sort or
something like that.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2018-03-28 13:51:06 | Re: [HACKERS] Partition-wise aggregation/grouping |
| Previous Message | Teodor Sigaev | 2018-03-28 13:28:01 | Re: [HACKERS] [PATCH] Incremental sort |