From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: password_encryption, default and 'plain' support |
Date: | 2017-05-08 08:27:10 |
Message-ID: | c64ebf34-4030-12e1-c3fe-3a4eaefd3a11@iki.fi |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 05/05/2017 03:42 PM, Michael Paquier wrote:
> + This option is obsolete but still accepted for backwards
> + compatibility.
> Isn't that incorrect English? It seems to me that this be non-plural,
> as "for backward compatibility".
I changed most cases to "backward compatibility", except the one in
create_role.sgml, because there were other instances of "backwards
compatibility" on that page, and I didn't want this to stick out.
> The comment at the top of check_password() in passwordcheck.c does not
> mention scram, you may want to update that.
Reworded the comment, to not list all the possible values.
> + /*
> + * We never store passwords in plaintext, so
> this shouldn't
> + * happen.
> + */
> break;
> An error here is overthinking?
It's not shown in the diff's context, but an error is returned just
after the switch statement. I considered leaving out the "case
PASSWORD_TYPE_PLAINTEXT" altogether, but then you might get compiler
warnings complaining that that enum value is not handled. I also
considered putting a an explicit "default:" there, which returns an
error, but then you'd again miss out on compiler warnings, if you add a
new password hash type and forget to add a case here to handle it.
> -- consistency of password entries
> -SET password_encryption = 'plain';
> -CREATE ROLE regress_passwd1 PASSWORD 'role_pwd1';
> SET password_encryption = 'md5';
> Nit: this is skipping directly to role number 2.
Renumbered the test roles.
Committed with those little cleanups. Thanks for the review!
- Heikki
From | Date | Subject | |
---|---|---|---|
Next Message | Tsunakawa, Takayuki | 2017-05-08 08:29:34 | Re: [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable. |
Previous Message | Rahila Syed | 2017-05-08 08:12:47 | Re: Adding support for Default partition in partitioning |