From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] pgbench: new feature allowing to launch shell commands |
Date: | 2009-09-18 06:10:14 |
Message-ID: | c64c5f8b0909172310l535c475vcc4acce5c538097@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>
> You really should be returning a value at the point since the function
> signature defines a return type. If not the function should be void,
> which it cannot be in this context since it is used for boolean tests
> elsewhere. The returns in question are all part of error blocks and
> should return false.
>
OK I got your point, I missed the part managing with CState, which is tested
after doCustom.
Another version of the patch is attached with this email.
I must be doing something wrong when I am running this script. It is
> still throwing errors. Would you mind showing me the pgbench command you
> used to run it?
>
> Of course, here it is the list of commands I use:
pgbench -i dbname (in case your database is called dbname)
pgbench -c 10 -t 10 -f transaction_file_name.data dbname (customer and
transaction numbers can also bet set as you want).
Regards,
--
Michael Paquier
NTT OSSC
Attachment | Content-Type | Size |
---|---|---|
postgresql-8.4.0-pgbenchshell4.0.patch | text/x-patch | 1.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Zdenek Kotala | 2009-09-18 06:43:59 | Re: [patch] pg_ctl init extension |
Previous Message | Simon Riggs | 2009-09-18 06:09:15 | Re: FSM search modes |