Re: File locks for data directory lockfile in the context of Linux namespaces

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Ilmar Yunusov <tanswis42(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: File locks for data directory lockfile in the context of Linux namespaces
Date: 2026-07-06 12:10:48
Message-ID: c5jj2zvhnh36xfvqkcogrvk5fkcut3un5q5hibozfm62h6t4kp@sdlorh7uaf2s
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Mon, Jul 06, 2026 at 07:30:04AM +0000, Ilmar Yunusov wrote:
>
> There is still a build blocker, matching the current CFBot failures. v3 adds a
> typedef named LockFile in src/backend/utils/init/miscinit.c, but that name
> conflicts with the Windows LockFile() function. The CompilerWarnings log
> reports, for example:

Thanks for looking into the build failure. I wanted to check it out what
was happening on Windows, but after the migration from Cirrus to Github
one have to be logged in to see the build logs, and at that moment I
found myself logged off.

Regarding the name, I'm afraid LockFileData has a chance of causing some
confusion due to a common pattern, where structures are named with
"Data" suffix and a pointer type definition without. Since it's about a
name clash with an external library, I suggest PGLockFile instead, but
open for better suggestions.

Attachment Content-Type Size
v4-0001-Use-open-file-description-locks-for-lockfiles.patch text/plain 12.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2026-07-06 12:18:20 Re: Can we get rid of TerminateThread() in pg_dump?
Previous Message Thomas Munro 2026-07-06 12:09:00 pg_threads.h take II