Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Ajin Cherian <itsajin(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <akapila(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>
Subject: Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command
Date: 2021-06-09 22:12:57
Message-ID: c5feaae9e7d94992303b157eba6a52c8a6cf9b88.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2021-06-09 at 16:50 +0530, Amit Kapila wrote:
> BTW, can't we consider it to be part of
> create_slot_opt_list?

Yes, that would be better. It looks like the physical and logical slot
options are mixed together -- should they be separated in the grammar
so that using an option with the wrong kind of slot would be a parse
error?

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2021-06-09 22:43:14 Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command
Previous Message Robert Haas 2021-06-09 21:03:00 Re: Race condition in recovery?