Re: [PATCH] standby: Clarify recovery conflict comment

On 11/13/26 09:19, Ankush Mondal wrote:
> if (GetCurrentTimestamp() >= ltime && ltime != 0)
> {
> /*
> - * We're already behind, so clear a path as quickly as possible.
> + * The standby delay has expired, so signal conflicting backends
> + * to release their buffer pins as quickly as possible.
> */
> SendRecoveryConflictWithBufferPin(RECOVERY_CONFLICT_BUFFERPIN);
> }

Hi,

Thanks for the patch but I do not think the new version is better. The
old version explained intent while the new comment just re-explains what
the code does. Maybe some mix of the two comments would be better but I
doubt it is worth the churn.

--
Andreas Karlsson
Percona